Send named pipe name to roslyn and razor #7273
Conversation
Pulled from #70913 (thanks @davidwengier!) Razor uses the intermediate path for project key. Now that we're removing the file system from being involved in communicating project data, we need to make sure we're communicating the right data. This fixes issues found in dotnet/vscode-csharp#7273 and will unblock that insertion
Co-authored-by: David Barbet <[email protected]>
|
@ryzngard looks like there is some issue with override completion on .net8 linux (consistently failing). Most likely caused by some roslyn change. I don't think I'll be able to look until next week (I'm out starting early afternoon tomorrow). I'm not sure the insertion can go in with the bug |
Can you force merge or do I need to ask a higher authority (as if there is one 😅) |
I can force merge this, but I don't think we should. There is definitely a regression caused by the roslyn changes that breaks override completion on linux. Until we figure out why and to what extent, I don't think we can release a change with this. |
|
Oh sorry, misread on mobile. Understood. I'll see if I can take a few minutes to look otherwise I can coordinate with you |
Update Roslyn to: https://dnceng.visualstudio.com/internal/_build/results?buildId=2491728&view=results
Update Razor to: https://dev.azure.com/dnceng/internal/_build/results?buildId=2484091&view=results