Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rzls.dll on macOS #7300

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented Jul 2, 2024

c2666b4 but for Razor

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2111269

My hypothesis is that now that we use nupkgs, our publishing happens on windows so can't be signed in a mac compatible way.

@davidwengier davidwengier marked this pull request as ready for review July 2, 2024 05:02
@davidwengier davidwengier requested a review from a team as a code owner July 2, 2024 05:02
@davidwengier davidwengier merged commit bc88ac1 into dotnet:main Jul 2, 2024
13 checks passed
@davidwengier davidwengier deleted the UseRzlsDllOnMac branch July 2, 2024 05:22
@dibarbet
Copy link
Member

dibarbet commented Jul 2, 2024

My hypothesis is that now that we use nupkgs, our publishing happens on windows so can't be signed in a mac compatible way.

Yeah if all your build and packaging happens on Windows mac executables won't be codesignd

@ryzngard
Copy link
Contributor

ryzngard commented Jul 2, 2024

My hypothesis is that now that we use nupkgs, our publishing happens on windows so can't be signed in a mac compatible way.

Yeah if all your build and packaging happens on Windows mac executables won't be codesignd

Is there a way we can build the nugets on macos? It seems like we were building on macos before so we have it as part of our pool. Maybe it won't be too hard to build mac on mac?

@dibarbet
Copy link
Member

dibarbet commented Jul 2, 2024

Is there a way we can build the nugets on macos? It seems like we were building on macos before so we have it as part of our pool. Maybe it won't be too hard to build mac on mac?

I assume its possible. Probably need to split your signed build into multiple parts (a windows step and mac step) and only build mac binaries on mac.

We haven't done it for Roslyn because its quite a bit of work to split our the signed build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants