Localize more strings #7305
Merged
Localize more strings #7305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Jul 3, 2024
| @@ -7,8 +7,6 @@ import { join } from 'path'; | |||
| import { execChildProcess } from '../common'; | |||
| import { CoreClrDebugUtil } from '../coreclrDebug/util'; | |||
|
|
|||
| export const MSBUILD_MISSING_MESSAGE = 'A valid msbuild installation could not be found.'; | |||
There was a problem hiding this comment.
This string was unused.
Comment on lines
-98
to
-99
| // Update decompilation authorization. | ||
| server.decompilationAuthorized = await getDecompilationAuthorization(context); |
There was a problem hiding this comment.
The acknowledgment was something we intended to remove to match the LspToolsHost behavior. Since it would be a lot to translate, I decided now was a good time to remove it.
Cosifne
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localizes strings displayed in message boxes and the settings editor. Removes unused string and O# decompilation acknowledgment prompt.
Resolves #7299