Fix handling files with non-Ascii characters by sending a TextDocumentIdentifier for dynamic file requests/responses #7442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
force-pushed
the
fix_utf_handling
branch
from
09dd6b9
to
ecd213a
Compare
dibarbet
reviewed
Aug 13, 2024
| @@ -24,6 +24,6 @@ export class UriConverter { | |||
| } | |||
|
|
|||
| public static deserialize(value: string): vscode.Uri { | |||
| return vscode.Uri.parse(value); | |||
| return vscode.Uri.parse(value, true); | |||
There was a problem hiding this comment.
it's the strict parameter. It causes it to throw if the Uri doesn't have a schema
…tIdentifier for dynamic file requests/responses
ryzngard
force-pushed
the
fix_utf_handling
branch
from
ecd213a
to
f63e170
Compare
ryzngard
commented
Aug 13, 2024
| export class RemoveDynamicFileParams { | ||
| constructor(public readonly razorFiles: DocumentUri[]) {} | ||
| constructor(public readonly csharpDocument: TextDocumentIdentifier) {} |
There was a problem hiding this comment.
so ironically I named this wrong in the original PR 😅. I'll get that fixed later
davidwengier
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code side of dotnet/roslyn#74727