Delete dotnet.dotnetPath option and migrate to replacement #7825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
force-pushed
the
migrate_dotnet_path
branch
from
26e5c51 to
320d55c
Compare
JoeRobich
approved these changes
Nov 26, 2024
dibarbet
force-pushed
the
migrate_dotnet_path
branch
from
320d55c to
d19c949
Compare
dibarbet
force-pushed
the
migrate_dotnet_path
branch
from
d19c949 to
98e9ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
dotnet.dotnetPathoption and adds support for migrating it to the replacement setting (defined by the .NET install tool).Resolves C# side of microsoft/vscode-dotnettools#1243
Prior to this change, both
dotnet.dotnetPathand the .NET Install Tool'sdotnetAcquisitionExtension.existingDotnetPathsetting both could influence the runtime that the server used. It is unnecessary to support both of these options at this point, and only causes needless confusion.Here we delete
dotnet.dotnetPathand migrate existing values todotnetAcquisitionExtension.existingDotnetPath. This should be unnoticeable in terms of behavior. The migration is slightly more complicated than other settings asdotnet.dotnetPathrequired a folder containing thedotnetexecutable whereas the .NET install tool setting requires the actual executable path.OmniSharp as not yet fully migrated over to the .NET install tool for .NET discovery, so O# users of
dotnet.dotnetPathwill be migrated toomnisharp.dotnetPath.