Don't immediately return promise within newly created promise #807
Conversation
DustinCampbell
force-pushed
the
fix-omnisharp-launchNix
branch
from
be47463 to
a880c20
Compare
| setTimeout(function () { | ||
| resolve(result); | ||
| }, 0); | ||
| }); |
There was a problem hiding this comment.
Is it normal that rejection of launch promise is not handled here?
There was a problem hiding this comment.
It's intended that rejection will be propagated to the caller, which is in server.ts here.
There was a problem hiding this comment.
If there is no reject callback AND the "launch" promise is not returned anywhere, I'm quite sure that the error will be silent.
This should be the correct way to bubble the error to the caller:
launch(details).then(result => {
// async error - when target not not ENEOT
result.process.on('error', reject);
// success after a short freeing event loop
setTimeout(function () {
resolve(result);
}, 0);
}).catch(reject);
| return Promise.resolve({ | ||
| process, | ||
| command: details.serverPath, | ||
| usingMono: false | ||
| }); |
There was a problem hiding this comment.
Why not putting all the code in a Promise like previously?
Any error there will end up in a throw which is not really what a function returning a promise should do.
There was a problem hiding this comment.
Any exceptions should ultimately be propagated to the caller in server.ts. The catch() there handles all rejections and exceptions.
Fixes #804