Add tests for VB runtime Do Not Review #11863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11863 +/- ##
===================================================
+ Coverage 75.66441% 75.74253% +0.07811%
===================================================
Files 3141 3150 +9
Lines 635604 637284 +1680
Branches 47012 47011 -1
===================================================
+ Hits 480926 482695 +1769
+ Misses 151230 151140 -90
- Partials 3448 3449 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@paul1956 main is now .NET 10.0 alpha and I have synced main with feature/10.0. I also retargeted your PR to main. On each of your branches, I believe you only need to run command |
paul1956
changed the title
…AddDependantTests
…AddDependantTests
…-Review-3rd-Feature-10
…AddDependantTests
…ts-for-VB-Runtime-Review-3rd-Feature-10
Co-authored-by: Loni Tra <[email protected]>
…Y.cs Co-authored-by: Loni Tra <[email protected]>
…nt/VARIANT.cs Co-authored-by: Loni Tra <[email protected]>
…/TestUtilities/TestData/DualTimeZones.TimeZoneNames.vb Co-authored-by: Loni Tra <[email protected]>
…-VB-Runtime-To-Be-Closed
…s-for-VB-Runtime-To-Be-Closed
…r-VB-Runtime-To-Be-Closed
…' into Add-Tests-for-VB-Runtime-To-Be-Closed
…sts-for-VB-Runtime-To-Be-Closed
paul1956
added a commit
to paul1956/winforms
that referenced
this pull request
Oct 23, 2024
paul1956
added a commit
to paul1956/winforms
that referenced
this pull request
Oct 23, 2024
lonitra
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Add Code Coverage for ComputerInfoDebugView * Improve tests on non Windows * Pr feedback * Remove Platform Test it should not be needed in ComputerInfoDebugView * Improve test coverage * Fix Debug.Assert in AssemblyInfo.vb * Remove non Windows Tests and make Fluent * Restore FileTraceListner code from PR Feedback.
paul1956
added a commit
to paul1956/winforms
that referenced
this pull request
Oct 23, 2024
paul1956
changed the title
lonitra
pushed a commit
that referenced
this pull request
Oct 25, 2024
paul1956
changed the title
|
This has been replaced with other small PR's |
dotnet-policy-service
bot
removed
the
waiting-review
lonitra
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Split Network.VB into 7 Files * Minor Cleanup * Remove m_ from private variable names and fix up event handler names and comments * Remove unused imports * Fix Debug.Assert in AssemblyInfo.vb * Cleanup Event Handler names * Fix incorrect naming of Private variables Shorten lines * Cleanup line length and spelling * Add missing CrLf * Simplify dialog.BeginInvoke * PR Feedback * PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5179 and uses Fluent Assertions
Proposed changes
Add tests for Network Download ONLY
Regression?
-No
Risk
Low - additional tests and code changes required to make them work
Microsoft Reviewers: Open in CodeFlow