Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for TrackBarRenderer #12427

Merged

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Nov 6, 2024

related #10453

Proposed changes
Add unit tests for TrackBarRenderer.cs to test its properties & methods

Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner November 6, 2024 01:30
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 96.33028% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.71467%. Comparing base (8c4acf0) to head (5f62847).
Report is 21 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12427         +/-   ##
===================================================
+ Coverage   75.64923%   75.71467%   +0.06543%     
===================================================
  Files           3149        3152          +3     
  Lines         635865      635709        -156     
  Branches       47018       46970         -48     
===================================================
+ Hits          481027      481325        +298     
+ Misses        151380      150948        -432     
+ Partials        3458        3436         -22     
Flag Coverage Δ
Debug 75.71467% <96.33028%> (+0.06543%) ⬆️
integration 18.26946% <ø> (+0.03716%) ⬆️
production 49.27151% <ø> (+0.08742%) ⬆️
test 97.05031% <96.33028%> (+0.01896%) ⬆️
unit 46.24977% <ø> (+0.08127%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Nov 6, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM.

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Nov 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Nov 7, 2024
@lonitra lonitra added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Nov 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Nov 8, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Nov 8, 2024
@lonitra lonitra added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Nov 8, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Nov 11, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit a3973fb into dotnet:main Nov 11, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 11, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_TrackBarRenderer branch November 12, 2024 01:05
paul1956 pushed a commit to paul1956/winforms that referenced this pull request Nov 13, 2024
* Add code coverage for TrackBarRenderer

* Handle FeedBacks

* Handle FeedBacks

* Handle FeedBacks

* Handle FeedBacks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants