Address non dark-mode coloring of listitem and treenode controls while in edit mode

[pcblues]

Fixes #12042 - TreeNode and ListItem not displaying in dark mode during editing, even though application is set to be in dark mode.

Proposed changes

If the application is in dark mode, capture the parent's windows message to identify the start of editing, and change the colour of the brush to match the parent's window color.

Customer Impact

Correction of incorrect color selection.

Regression?

• Yes / No

Risk

I tried to limit the impact of the change to only occurring when the application is in dark mode. I'm not sure of the impact, if any, on custom ListView subitems, or custom-drawn TreeNodes.

Screenshots

Before

After

Test methodology

I used the test application provided to highlight the bug in the ticket to test the new behaviour.

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 76.17915%. Comparing base (9780820) to head (29c8b90).

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #12674         +/-   ##
===================================================
- Coverage   76.18717%   76.17915%   -0.00802%     
===================================================
  Files           3193        3193                 
  Lines         640306      640334         +28     
  Branches       47237       47239          +2     
===================================================
- Hits          487831      487801         -30     
- Misses        148942      149001         +59     
+ Partials        3533        3532          -1     

Flag	Coverage Δ
Debug	76.17915% <21.42857%> (-0.00802%)	⬇️
integration	18.15165% <0.00000%> (-0.02646%)	⬇️
production	50.11282% <21.42857%> (-0.01549%)	⬇️
test	97.02313% <ø> (ø)
unit	47.53694% <21.42857%> (-0.00538%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[pcblues]

Hi there. I'm not sure what to do with the codecov report. For perspective, I have been a developer for 20 odd years, but haven't done changes through github for MS before. Cheers.

[pcblues]

@pcblues please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@dotnet-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

[pcblues]

This is my first PR for MS. I didn't really understand what was happening with the accessibility testing software.

[KlausLoeffelmann]

Hey @pcblues,

2 general issues I have on first sight with this PR:

1. We are using DLL imports from CSWin32. Take a look at other samples how to utilize those and adapt the approach accordingly.

2. We need to make sure we're not clashing with this approach when the users themselves are using owner drawing.

The latter issue is actually one where I would need to think about a bit more, if owner drawing is the way to go. Have you tested this with different HighDPI-Modes and other Font(s/ sizes) than the default font? Does that still work? Could you also try it in PMV2 with different Resolutions on the monitors? Thanks!