Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for MaskedTextBoxDesigner #12779

Conversation

Nora-Zhou01
Copy link
Member

@Nora-Zhou01 Nora-Zhou01 commented Jan 14, 2025

Related #10773

Proposed changes

  • Add unit test MaskedTextBoxDesignerTests.cs for public properties and method of the MaskedTextBoxDesigner
  • Enable nullability in MaskedTextBoxDesignerTests.cs
Microsoft Reviewers: Open in CodeFlow

@Tanya-Solyanik
Copy link
Member

src\System.Windows.Forms.Design\tests\UnitTests\System\Windows\Forms\Design\MaskedTextBoxDesignerTests.cs(60,9): error CS8602: (NETCORE_ENGINEERING_TELEMETRY=Build) Dereference of a possibly null reference

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jan 14, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.13477%. Comparing base (e91e3bc) to head (209eae4).
Report is 191 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12779         +/-   ##
===================================================
+ Coverage   75.75455%   76.13477%   +0.38022%     
===================================================
  Files           3159        3223         +64     
  Lines         635942      641980       +6038     
  Branches       46987       47234        +247     
===================================================
+ Hits          481755      488770       +7015     
+ Misses        150726      149666       -1060     
- Partials        3461        3544         +83     
Flag Coverage Δ
Debug 76.13477% <98.68421%> (+0.38022%) ⬆️
integration 18.07336% <ø> (-0.10142%) ⬇️
production 50.04262% <ø> (+0.72507%) ⬆️
test 96.97830% <98.68421%> (-0.06677%) ⬇️
unit 47.47856% <ø> (+0.94686%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label Jan 16, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 17, 2025
@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Jan 18, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 22, 2025
@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Jan 22, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 23, 2025
ricardobossan
ricardobossan previously approved these changes Jan 23, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ricardobossan ricardobossan requested review from Tanya-Solyanik and removed request for Tanya-Solyanik January 23, 2025 18:48
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Jan 23, 2025
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 24, 2025
@Tanya-Solyanik Tanya-Solyanik enabled auto-merge (squash) January 24, 2025 01:41
@Tanya-Solyanik Tanya-Solyanik merged commit 5fc66aa into dotnet:main Jan 24, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-author-feedback The team requires more information from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants