Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdk.version entry to global.json #2718

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Add sdk.version entry to global.json #2718

merged 1 commit into from
Mar 5, 2020

Conversation

vatsan-madhavan
Copy link
Member

@vatsan-madhavan vatsan-madhavan commented Mar 5, 2020 •
edited
Loading

Adds sdk.version entry to global.json which tells msbuild SDK resolver which SDK version to look for when looking for Microsoft.NET.Sdk

Detailed explanation at #2714 (comment)

Fixes #2714

@ghost ghost requested a review from rladuca March 5, 2020 20:06
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Mar 5, 2020
@ghost ghost requested a review from SamBent March 5, 2020 20:06
@vatsan-madhavan vatsan-madhavan changed the title Adds sdk.version entry Add sdk.version entry to global.json Mar 5, 2020
@rladuca rladuca merged commit ac01f8c into dotnet:master Mar 5, 2020
@vatsan-madhavan vatsan-madhavan deleted the build-sdk-fixup branch March 5, 2020 21:39
@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rladuca rladuca rladuca approved these changes

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to compile using build.cmd file
2 participants
@vatsan-madhavan @rladuca