Replace DoubleUtil.IsNaN with double.IsNaN #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
gfoidl
reviewed
Apr 1, 2021
| @@ -1403,8 +1403,8 @@ private static void RenderTransform_Changed(DependencyObject d, DependencyProper | |||
| private static bool IsRenderTransformOriginValid(object value) | |||
| { | |||
| Point v = (Point)value; | |||
| return ( (!DoubleUtil.IsNaN(v.X) && !Double.IsPositiveInfinity(v.X) && !Double.IsNegativeInfinity(v.X)) | |||
| && (!DoubleUtil.IsNaN(v.Y) && !Double.IsPositiveInfinity(v.Y) && !Double.IsNegativeInfinity(v.Y))); | |||
| return ( (!double.IsNaN(v.X) && !Double.IsPositiveInfinity(v.X) && !Double.IsNegativeInfinity(v.X)) | |||
There was a problem hiding this comment.
These checks could use double.IsNormal instead of IsNan, IsPositiveInfinity, and IsNegativeInfinity.
Same on other places.
But this API isn't available on .NET Full, only starting at .NET Core 2.1 and .NET Standard 2.1.
Instead of IsPositiveInfinity and IsNegativeInfinity use just double.IsInfinity.
There was a problem hiding this comment.
I would implement it in a separate PR.
This one just mechanically replaces one call with another.
ayushverma-ms
approved these changes
Sep 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #4338
Description
Replaces DoubleUtil.IsNaN with double.IsNaN which is times faster.
Customer Impact
Regression
Testing
I haven't managed to build the project.
Risk