You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main focus was on the FindCommandBinding method in CommandManager.cs. Here I decided to use a ValueTuple instead of a Tuple as well as to do the check using a switch-is block, as this is most likely easier to optimize through the JIT.
Furthermore, I made other code improvements in related methods, like reducing code-nesting and using new C# features.
I don't think these make a big difference to the generated JIT asm, but still hope to have made the code a bit more readable.
I do not believe this fixes #4869 because the algorithm itself is quite inefficient to my understanding.
Looking at your changes those are mosly refactorings in favour of new language features. Or did I miss something?
I do not believe this fixes #4869 because the algorithm itself is quite inefficient to my understanding. Looking at your changes those are mosly refactorings in favour of new language features. Or did I miss something?
The usage of ValueTuples instead of Tuples might improve the performance a little bit. But I don't know how to benchmark WPF Code because BenchmarkDotNet does not work with this workset
ghost
locked as resolved and limited conversation to collaborators
Apr 6, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
PRmetadata: Label to tag PRs, to facilitate with triage
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
ghost
requested review from
Might fix Issue #4869
Description
The main focus was on the FindCommandBinding method in CommandManager.cs. Here I decided to use a ValueTuple instead of a Tuple as well as to do the check using a switch-is block, as this is most likely easier to optimize through the JIT.
Furthermore, I made other code improvements in related methods, like reducing code-nesting and using new C# features.
I don't think these make a big difference to the generated JIT asm, but still hope to have made the code a bit more readable.
/cc @IAmTheCShark