Optimize the code of OSVersionHelper #6252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can not run the WPF application in the system which version lower than win7.
ghost
added
the
ghost
requested review from
|
@lindexi Do we have a benchmark for this? |
|
@dipeshmsft Sorry, I do not know how to test it. Can you tell me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can not run the WPF application in the system which version lower than win7. And it will return fast without call the RtlVerifyVersionInfo method.
Customer Impact
Improve performance?
Regression
None.
Testing
Just CI.
Risk
Low.