Remove substring allocation from Baml2006Reader.Logic_GetFullXmlns #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the assembly name, we can slice out the piece that's needed rather than allocating a substring.
ghost
requested review from
dipeshmsft
added
the
📭 waiting-author-feedback
|
@dipeshmsft, you marked this as needs-author-feedback, but I don't see a question; is there something you need? |
|
In the review I have left a comment. |
I do not see it. Where? What does it say? |
dipeshmsft
reviewed
May 20, 2022
...rosoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Markup/Baml2006/Baml2006Reader.cs
Show resolved
Hide resolved
dipeshmsft
removed
the
📭 waiting-author-feedback
dipeshmsft
approved these changes
May 20, 2022
This was referenced Jun 9, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When getting the assembly name, we can slice out the piece that's needed rather than allocating a substring.
Customer Impact
Unnecessary string allocations.
Regression
No
Testing
CI
Risk
Minimal