Try fix the first point in StylusPlugin in high DPI #6428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
requested review from
…ixStylusPluginHightDpi
…ixStylusPluginHightDpi
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dotnet-policy-service rerun |
rchauhan18
approved these changes
Nov 24, 2023
|
Thanks @lindexi for your contribution! |
|
Thank you @rchauhan18 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6415
Description
After #2891 , we call calculate the point with
stylusDevice.CriticalActiveSource. But thestylusDevice.CriticalActiveSourcemust be null when first touch down, because the wpf do not touch any element and do not get the AcitveSource before first touch down.We should input the PresentationSource to
GetAndCacheTransformToDeviceMatrixto get the expected Matrix. So I replace thereport.InputSourcetostylusDevice.CriticalActiveSourcewhen thestylusDevice.CriticalActiveSourceis null.Customer Impact
Fix #6415
The coordinates of the points are correct in StylusPlugin.
Regression
Regression in PR #2891
Testing
I test the code in my touch screen with high DPI. And I build it in https://github.com/dotnet-campus/wpf/actions/runs/2164903389
Risk
All of the application which run in the device with touch screen.
@rladuca Could you review my code?
Microsoft Reviewers: Open in CodeFlow