Avoid unnecessary List<> wrapper in GetTextRunSpans
#6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
dipeshmsft
approved these changes
May 19, 2022
This was referenced Jun 9, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We know exactly how big the resulting list needs to be. As is done in other variants of this method, just allocate the array to be used as an IList. Also in one place where we do continue using a
List<T>, strongly-type the local as such to avoid unnecessarily going through the interface.Customer Impact
Unnecessary allocation
Regression
No
Testing
CI
Risk
Minimal. Other implementations already return arrays, so callers can't be expecting it'll always be a
List<>.Microsoft Reviewers: Open in CodeFlow