Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate PackageReference Microsoft.Private.Winforms #6648

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Remove duplicate PackageReference Microsoft.Private.Winforms #6648

merged 1 commit into from
Jun 17, 2022

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Jun 4, 2022 •
edited by ghost
Loading

Contributes to #6647

Description

Removes duplicate PackageReference for Microsoft.Private.Winforms, it is already added here:

wpf/eng/WpfArcadeSdk/tools/SdkReferences.targets

Lines 3 to 10 in 42a8bbe

<PackageReference Include="$(MicrosoftPrivateWinformsPackage)"
Version="$(MicrosoftPrivateWinformsVersion)"
ExcludeAssets="All"
GeneratePathProperty="True"
Condition="'$(MSBuildProjectExtension)'!='.vcxproj'
And '$(TargetFrameworkIdentifier)' == '.NETCoreApp'
And $([MSBuild]::VersionGreaterThanOrEquals('$(TargetFrameworkVersion)', '3.0'))
And '$(NoAutoMicrosoftPrivateWinformsReference)'!='true'"/>

Duplicate PackageReference is a build error in VS 2022 Preview (I have the error on 17.3.0 Preview 1.1).

Customer Impact

None.

Regression

No.

Testing

Local build + CI.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested a review from a team as a code owner June 4, 2022 20:58
@ghost ghost assigned ThomasGoulet73 Jun 4, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 4, 2022
@ghost ghost requested review from dipeshmsft, singhashish-wpf and SamBent June 4, 2022 20:58
@ghost ghost added the Community Contribution A label for all community Contributions label Jun 4, 2022
@ThomasGoulet73 ThomasGoulet73 mentioned this pull request Jun 4, 2022
Closed
@dipeshmsft dipeshmsft mentioned this pull request Jun 17, 2022
Merged
@dipeshmsft dipeshmsft merged commit 442cd2f into dotnet:main Jun 17, 2022
@ThomasGoulet73 ThomasGoulet73 deleted the remove-duplicate-Microsoft.Private.Winforms branch June 17, 2022 14:54
@wtgodbe wtgodbe mentioned this pull request Jun 20, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@ThomasGoulet73 ThomasGoulet73

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasGoulet73 @dipeshmsft