Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation support #3

Open
squallsama opened this issue Nov 7, 2019 · 3 comments
Open

Add translation support #3

squallsama opened this issue Nov 7, 2019 · 3 comments

Comments

@squallsama
Copy link

Right now there is only English version of instructions available via API. It would be great to have ability to get translated text for different languages. If you need any help, then I would be glad to collaborate.

@fennifith
Copy link
Contributor

I'll point to urbandroid-team/dont-kill-my-app#70 in saying it unfortunately doesn't seem like there are plans to support localization in DKMA (if there were, that would be the place to contribute them). I don't necessarily agree with this response, as I think that even incomplete or out of date translations are better than not having any at all, but I respect their decision. It might be good to bring up the discussion again though, and have a look at how it might be implemented in a way that doesn't require as much support from maintainers.

Anyone is welcome to translate the strings in this repo though, which are a lot less maintenance-heavy (as they're only used on a few buttons and UI elements). The translated file should be strings-[locale].xml in the same directory, or you can just send them to me and I'll put them in. I might actually be able to translate a few of these myself :P

It seems I've been somewhat negligent in documenting the contribution process here; I usually try to place this information in the README when possible. Oops.

@squallsama
Copy link
Author

I'll point to urbandroid-team/dont-kill-my-app#70 in saying it unfortunately doesn't seem like there are plans to support localization in DKMA (if there were, that would be the place to contribute them). I don't necessarily agree with this response, as I think that even incomplete or out of date translations are better than not having any at all, but I respect their decision. It might be good to bring up the discussion again though, and have a look at how it might be implemented in a way that doesn't require as much support from maintainers.

Anyone is welcome to translate the strings in this repo though, which are a lot less maintenance-heavy (as they're only used on a few buttons and UI elements). The translated file should be strings-[locale].xml in the same directory, or you can just send them to me and I'll put them in. I might actually be able to translate a few of these myself :P

It seems I've been somewhat negligent in documenting the contribution process here; I usually try to place this information in the README when possible. Oops.

Thanks! Will take a look on string.xml. From my vision it's better to have options in json response related to languages.

@Artaud
Copy link

Artaud commented Dec 4, 2019

Hey guys, we've currently started work on running the content on DKMA through Google Translate so it will be available through the API machine-translated.
Please see urbandroid-team/dont-kill-my-app#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants