-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option for update information #357
Add config option for update information #357
Conversation
@Sab44 Hm I had the issue first as well but had fixed it by adding the proper string translation. What language are you using? Can you please check if there are any errors showing up in your logs that might help debugging this? |
HA is in english. All the other strings on this form appear fine. |
@Sab44 you're right, I missed that one. Added it now. I think, after updating, you would need to restart HA in order to see any effects. If you have a testing environment, maybe you can try :-) |
Hey @uneart it's showing up properly now 👍 |
This implementation is not complete, let me think and see if another approach works. In the next few weeks I will come back with a definitive solution. Thanks! |
The code to ignore the missing permission repair has been fixed (#371). I think it is simpler and more practical for the user than adding another configuration option. Previously, even ignoring the repair would reappear after restarting or reloading the integration. This has now been fixed. Thanks for the contribution anyway. |
Fixes #334
Proposal for an additional option to disable the update information coordinator. This would fix repair warnings for users not willing to give
Sys.Modify
permissions to the Proxmox user/group.@dougiteixeira please review if this goes into the right direction from your point of view.
I tested this on my staging Home Assistant instance and it seems to work as expected.
Open tasks