-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VoiceOver cannot find listbox contents using swipe gesture #779
Comments
You are right, we should change the Downshift examples in:
I can take this but I can also code review if you can do it faster. Thank you very much! |
@silviuavram I can help with testing but will need someone else make the actual changes (I'm not a developer). Thanks! |
After looking over it it may need a bit more than the changes in the list above.
I am in favour of leaving |
@silviuavram Whats the status? |
Got same issue and had a bit investigation, I think even we follow the structure as the combobox example from W3, and apply all those aria attributes, may still not fix the issue completely. When using voice over on ios device, swipe gesture will trigger the I think in Can anyone help to verify and look into this? Thank you :) |
I think we should create another I finished |
@fymmot @huizhiTS @itstheGoodstuff please review the PR above. See if it's correct and also leave suggestions. Thanks! |
🎉 This issue has been resolved in version 4.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
downshift
version: 3.3.4node
version: N/A (only tested on demo page)npm
(oryarn
) version: N/A (only tested on demo page)Equipment
What you did:
What happened:
Problem description:
The issue appears to be
aria-owns
not working properly in VoiceOver on iOS. It's not creating the expected DOM order for the listbox in relation to the input.The problem does not exist with Talkback on Android.
Suggested solution:
Compare with the Authoring Practices example (https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html) which has the expected behavior in VoiceOver. I can find the suggestions as expected by swiping forward from the input field.
One possible reason is that the listbox in the Authoring Practices example is placed as a sibling to the combobox in the DOM, instead of as its child, as done in Downshift:
Authoring Practices example structure
Current Downshift structure:
I recommend we look into replicating the Authoring practices structure, as long as
aria-owns
is broken on iOSThe text was updated successfully, but these errors were encountered: