docs: combobox HTML correct structure in documentation #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
changed the title
Codecov Report
@@ Coverage Diff @@
## master #867 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 886 886
Branches 184 184
=====================================
Hits 886 886Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes #779.
Why:
The main
Downshiftuse example is not accessible with screen readers. The HTML structure for acomboboxis not achievable without using getRootProps.How:
Change main Downshift usage example. Added more information on why is it important to use that instead of the previous one. Also added a docs page for both these usages.
Checklist: