Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSelect: add Windows Arrow Up/Down on button behavior #792

Closed
silviuaavram opened this issue Oct 14, 2019 · 2 comments · Fixed by #1044
Closed

useSelect: add Windows Arrow Up/Down on button behavior #792

silviuaavram opened this issue Oct 14, 2019 · 2 comments · Fixed by #1044
Labels
enhancement released

Comments

@silviuaavram
Copy link
Collaborator

As a follow up of WordPress/gutenberg#16473, the custom select can have a Windows specific behavior:

  • on toggleButton, on ArrowUp/Down, it will not expand the dropdown, but will just select the next/previous without opening the list.
  • should be implemented inside useSelect and provided as a feature under a boolean prop.
@silviuaavram
Copy link
Collaborator Author

Not worth the extra prop. I will change the useSelect example with `stateReducer in the docsite to reflect this behavior, since it is more realistic than the one we have now.

@silviuaavram silviuaavram mentioned this issue May 9, 2020
Merged
5 tasks
@silviuaavram
Copy link
Collaborator Author

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(useSelect): change the docsite stateReducer example downshift-js/downshift
1 participant
@silviuaavram