Migrating the Apollo Example to downshift-examples

[haffmaestro]

Thinking about migrating the Apollo Example. But unsure as to what the recommendation is for async rendering of items. Having read, #186 and noticing that all of the new hooks take items as an argument.

What are your thoughts on comboboxes with async items?

Thanks!

[silviuaavram]

That example should stay as it is, with Downshift component.

If you want to create an async version with useSelect or useCombobox (or both!) please create a separate one and we can add it in the docsite.

I did not create any example using async items so it might be very helpful if you can try it out :)

[haffmaestro]

@silviuaavram Right that makes sense regarding the Apollo example, I think doing useSelect or useCombobox with async items might be a little weird, have been playing with it though.

[ndeom]

Hi, is this is this issue still up for grabs? I saw the good first issue tag and thought I would ask.

[silviuaavram]

Hi @ndeom ! It's still open, let us know if you are creating a PR for it.

[ndeom]

Sure! I just wanted to quickly discuss the scope of what you would like done before I do. I've taken a look at the Apollo example referenced above, and I'm assuming that you would like this example replicated with the useSelect and useCombobox hooks instead of the Downshift component on codesandbox. Do you want the documentation updated for both hooks to include the examples?

[ndeom]

@silviuaavram I found some time to redo the Apollo example with the useSelect hook and realized that Apollo had somewhat recently updated to Apollo Client 3.0, which uses the useQuery hook inside of functional components for queries rather than creating higher-order components. Would you like this part of the example updated as well?

[silviuaavram]

Definitely, let’s do that. 😎

…

On Tue, 21 Jul 2020 at 18:22, Nick Deom ***@***.***> wrote: @silviuaavram <https://github.com/silviuaavram> I found some time to redo the Apollo example with the useSelect hook and realized that Apollo had somewhat recently updated to Apollo Client 3.0, which uses the useQuery hook inside of functional components for queries rather than creating higher-order components. Would you like this part of the example updated as well? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#997 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWAZACR4PE3G3G7YIROR5TR4WXBRANCNFSM4MG66CCQ> .

[ndeom]

@silviuaavram apologies for the delay. Here are links to updated examples for useSelect and useCombobox:
(useSelect) https://codesandbox.io/s/useselect-apollo-example-cglg3?file=/src/index.js
(useCombobox) https://codesandbox.io/s/usecombobox-apollo-example-qhvul?file=/src/index.js .
I tried to make them as similar as possible to the other examples for both of these hooks. I'd really appreciate if you could take a quick look and let me know if these are acceptable. I also have both of them added to the example repo ready for a PR:
https://codesandbox.io/s/downshift-examples-cik7s?file=/src/other-examples/apollo-useCombobox/index.js

[ndeom]

@silviuaavram just letting you know I created a PR in the example repo

[kentcdodds]

Looks like this is done 👍