-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mofonetprofiles 294 create dox graph db consumer batching #9
Open
bsimpson
wants to merge
7
commits into
master
Choose a base branch
from
MOFONETPROFILES-294-create-dox-graph-db-consumer-batching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mofonetprofiles 294 create dox graph db consumer batching #9
bsimpson
wants to merge
7
commits into
master
from
MOFONETPROFILES-294-create-dox-graph-db-consumer-batching
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to pass in multiple statements into the same HTTP API request.
rstawarz
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiphani
reviewed
Sep 15, 2022
bsimpson
force-pushed
the
MOFONETPROFILES-294-create-dox-graph-db-consumer-batching
branch
from
September 15, 2022 18:59
449cab7
to
41cc584
Compare
Tiphani
approved these changes
Sep 15, 2022
This client inherits from the default client but overrides the actions associated with node and relationship manipulation To run commands in batch you can now instantiate a transaction like: Neo4j::Http::Client.in_batch do |tx| [ tx.upsert_node(node), tx.upsert_node(node2), tx.upsert_relationship(relationship: relationship, from: from, to: to) ] end The array of statements will be passed into a batch client that will prepare the statements and the parameters and issue a single request to the Neo4j HTTP API. Note that the size of the batch is determined by the caller's array length.
bsimpson
force-pushed
the
MOFONETPROFILES-294-create-dox-graph-db-consumer-batching
branch
from
September 16, 2022 18:57
324813d
to
95266f6
Compare
rstawarz
reviewed
Sep 16, 2022
The batch client subclasses are now provided a provide_xxx method that can be overridden to format into a statement syntax for batching
bsimpson
force-pushed
the
MOFONETPROFILES-294-create-dox-graph-db-consumer-batching
branch
from
September 22, 2022 13:59
4daa236
to
a68ba63
Compare
rstawarz
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA story: https://doximity.atlassian.net/browse/MOFONETPROFILES-294
Overview
Adds a new batch client
Technical Information