Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how Wi-Fi network info is received on Mac #259

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

pratnala
Copy link
Contributor

@pratnala pratnala commented Apr 8, 2024

The airport command is now deprecated on macOS 14.4+. Changing it to use the networksetup command to get this information instead based on suggestions in #256.

@ethancedwards8
Copy link
Member

Is this solution backwards compatible?

@pratnala
Copy link
Contributor Author

pratnala commented Apr 9, 2024

Yes, I believe it is an old BSD command so it should work on older versions of macOS (<14.4) too

@ethancedwards8
Copy link
Member

Tested it with an older device I have. Worked. Thank you!

@ethancedwards8 ethancedwards8 merged commit c2b1d67 into dracula:master Apr 10, 2024
1 check passed
@pratnala pratnala deleted the patch-1 branch April 10, 2024 05:47
@pratnala
Copy link
Contributor Author

This is broken in Sequoia. #291 is a possible fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants