Formatting Pull Request #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemilpanchiwala
requested review from
matthiaskoenig,
draeger,
shalinshah1993 and
zakharc
and removed request for
matthiaskoenig
zakharc
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Looks good to me.
@draeger, @matthiaskoenig, @shalinshah1993: Please note the "google-specific" 2-space indentation. If you used to standard 4-space indentation, now is a good time to change this.
In fact, I am very much in favor of 2 space indentation because it does not waste valuable space on the screen that does not have extra information. With this, more code in different windows can be viewed and be simultaneously compared. |
draeger
approved these changes
Aug 14, 2020
draeger
requested changes
Aug 16, 2020
src/test/java/org/simulator/stochastic/StochasticTestSuiteTest.java
Outdated
Show resolved
Hide resolved
draeger
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats all the classes of SBSCL according to the Java code style present in the dev folder.