Use PEP 585 syntax for types #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://peps.python.org/pep-0585/#implementation Fixes ManimCommunity/manim#3719 (comment) ``` File "/Users/michol/opt/anaconda3/lib/python3.9/site-packages/manim_data_structures/m_array.py", line 630, in MArray def __calc_label_pos_and_mob(self) -> typing.Tuple[Square, np.ndarray]: AttributeError: module 'manim.typing' has no attribute 'Tuple' ``` A rapid migration to https://peps.python.org/pep-0585/#implementation might improve reliability.
|
I'd appreciate if you'd cater to all instances of |
This is already done because neither
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://peps.python.org/pep-0585/#implementation
Fixes ManimCommunity/manim#3719 (comment)
A rapid migration to https://peps.python.org/pep-0585/#implementation might improve reliability.
The wildcard import
from manim import *on line 7 is a bad idea as discussed in PEP 8.