fix staticcheck failures

Signed-off-by: SataQiu <[email protected]>

client/request.go

@@ -108,6 +108,7 @@ func (client *APIClient) hijack(ctx context.Context, path string, query url.Valu
 		tcpConn.SetKeepAlivePeriod(30 * time.Second)
 	}
 
+	//lint:ignore SA1019 we do not migrate this to 'net/http.Client' as it does not implement Hijack now.
 	clientconn := httputil.NewClientConn(conn, nil)
 	defer clientconn.Close()
 
@@ -142,6 +143,8 @@ func (client *APIClient) sendRequest(ctx context.Context, method, path string, q
 		return nil, err
 	}
 
+	req = req.WithContext(ctx)
+
 	resp, err := cancellableDo(ctx, client.HTTPCli, req)
 	if err != nil {
 		return nil, err
@@ -181,8 +184,6 @@ func cancellableDo(ctx context.Context, client *http.Client, req *http.Request)
 
 	select {
 	case <-ctx.Done():
-		tr := client.Transport.(*http.Transport)
-		tr.CancelRequest(req)
 		<-ctxResp
 		return nil, ctx.Err()
 

dfget/core/api/supernode_api_test.go

@@ -71,13 +71,15 @@ func (s *SupernodeAPITestSuite) TestSupernodeAPI_Register(c *check.C) {
 	res := types.RegisterResponse{BaseResponse: &types.BaseResponse{}}
 	s.mock.PostJSONFunc = s.mock.CreatePostJSONFunc(200, []byte(res.String()), nil)
 	r, e = s.api.Register(localhost, createRegisterRequest())
+	c.Assert(e, check.IsNil)
 	c.Assert(r, check.NotNil)
 	c.Assert(r.Code, check.Equals, 0)
 
 	res.Code = constants.Success
 	res.Data = &types.RegisterResponseData{FileLength: int64(32)}
 	s.mock.PostJSONFunc = s.mock.CreatePostJSONFunc(200, []byte(res.String()), nil)
 	r, e = s.api.Register(localhost, createRegisterRequest())
+	c.Assert(e, check.IsNil)
 	c.Assert(r, check.NotNil)
 	c.Assert(r.Code, check.Equals, constants.Success)
 	c.Assert(r.Data.FileLength, check.Equals, res.Data.FileLength)
@@ -140,6 +142,7 @@ func (s *SupernodeAPITestSuite) TestSupernodeAPI_get(c *check.C) {
 	c.Assert(e.Error(), check.Equals, "0:test", check.Commentf(m))
 
 	r, e, m = f(0, "x", fmt.Errorf("test error"))
+	c.Assert(r.A, check.Equals, 0, check.Commentf(m))
 	c.Assert(e.Error(), check.Equals, "test error", check.Commentf(m))
 
 	r, e, m = f(200, "x", nil)

dfget/core/uploader/peer_server_test.go

@@ -77,10 +77,10 @@ func (s *PeerServerTestSuite) TearDownSuite(c *check.C) {
 func (s *PeerServerTestSuite) TestGetTaskFile(c *check.C) {
 	// normal test
 	f, _, err := s.srv.getTaskFile(commonFile)
-	defer f.Close()
 	// check get file correctly
 	c.Assert(err, check.IsNil)
 	c.Assert(f, check.NotNil)
+	defer f.Close()
 	// check read file correctly
 	result, err := ioutil.ReadAll(f)
 	c.Assert(err, check.IsNil)

dfget/core/uploader/uploader.go

@@ -173,8 +173,8 @@ func serverGC(cfg *config.Config, interval time.Duration) {
 }
 
 func captureQuitSignal() {
-	c := make(chan os.Signal)
-	signal.Notify(c, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM, syscall.SIGSTOP)
+	c := make(chan os.Signal, 1)
+	signal.Notify(c, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM)
 	s := <-c
 	logrus.Infof("capture stop signal: %s, will shutdown...", s)
 

supernode/daemon/mgr/dfgettask/manager_test.go

@@ -184,6 +184,7 @@ func (s *DfgetTaskMgrTestSuite) TestDfgetTaskUpdate(c *check.C) {
 		}
 
 		dt, err := manager.Get(context.Background(), tc.dfgetTask.CID, tc.dfgetTask.TaskID)
+		c.Check(err, check.IsNil)
 		c.Check(dt, check.DeepEquals, tc.Expect)
 	}
 }