fix(client): add error handling in client

Signed-off-by: hwdef <[email protected]>

client/peer_delete.go

@@ -26,6 +26,8 @@ func (client *APIClient) PeerDelete(ctx context.Context, id string) error {
 	if err != nil {
 		return err
 	}
-	ensureCloseReader(resp)
+	if err := ensureCloseReader(resp); err != nil {
+		return err
+	}
 	return nil
 }

client/request.go

@@ -104,8 +104,12 @@ func (client *APIClient) hijack(ctx context.Context, path string, query url.Valu
 	}
 
 	if tcpConn, ok := conn.(*net.TCPConn); ok {
-		tcpConn.SetKeepAlive(true)
-		tcpConn.SetKeepAlivePeriod(30 * time.Second)
+		if err := tcpConn.SetKeepAlive(true); err != nil {
+			return nil, nil, err
+		}
+		if err := tcpConn.SetKeepAlivePeriod(30 * time.Second); err != nil {
+			return nil, nil, err
+		}
 	}
 
 	clientconn := httputil.NewClientConn(conn, nil)

client/task_delete.go

@@ -26,6 +26,8 @@ func (client *APIClient) TaskDelete(ctx context.Context, id string) error {
 	if err != nil {
 		return err
 	}
-	ensureCloseReader(resp)
+	if err := ensureCloseReader(resp); err != nil {
+		return err
+	}
 	return nil
 }

client/task_update.go

@@ -29,6 +29,8 @@ func (client *APIClient) TaskUpdate(ctx context.Context, id string, config *type
 		return err
 	}
 
-	ensureCloseReader(resp)
+	if err := ensureCloseReader(resp); err != nil {
+		return err
+	}
 	return nil
 }

client/utils.go

@@ -31,10 +31,13 @@ func decodeBody(obj interface{}, body io.Reader) error {
 	return nil
 }
 
-func ensureCloseReader(resp *Response) {
+func ensureCloseReader(resp *Response) error {
 	if resp != nil && resp.Body != nil {
+		defer resp.Body.Close()
+
 		// close body ReadCloser to make Transport reuse the connection
-		io.CopyN(ioutil.Discard, resp.Body, 512)
-		resp.Body.Close()
+		_, err := io.CopyN(ioutil.Discard, resp.Body, 512)
+		return err
 	}
+	return nil
 }