Merge pull request #1310 from tanjunchen/improve-code

enhancement: improve GCDSlice performance
dragonflyoss · Apr 28, 2020 · 4eda7c3 · 4eda7c3
2 parents ca96df3 + e73614c
commit 4eda7c3
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/pkg/algorithm/algorithm.go b/pkg/algorithm/algorithm.go
@@ -27,8 +27,14 @@ func GCDSlice(s []int) int {
 	if length == 1 {
 		return s[0]
 	}
-
-	return GCD(s[length-1], GCDSlice(s[:length-1]))
+	commonDivisor := s[0]
+	for i := 1; i < length; i++ {
+		if commonDivisor == 1 {
+			return commonDivisor
+		}
+		commonDivisor = GCD(commonDivisor, s[i])
+	}
+	return commonDivisor
 }
 
 // GCD returns the greatest common divisor of x and y.