supernode: cleanup code based on static check warning

Signed-off-by: hwdef <[email protected]>

pkg/util/assert.go

@@ -56,7 +56,7 @@ func IsNil(value interface{}) bool {
 
 // IsTrue returns whether the value is true.
 func IsTrue(value bool) bool {
-	return value == true
+	return value
 }
 
 // IsPositive returns whether the value is a positive number.

supernode/daemon/mgr/cdn/cdn_gc.go

@@ -58,7 +58,7 @@ func (cm *Manager) GetGCTaskIDs(ctx context.Context, taskMgr mgr.TaskMgr) ([]str
 
 	// walkTaskIDs is used to avoid processing multiple times for the same taskID
 	// which is extracted from file name.
-	walkTaskIDs := make(map[string]bool, 0)
+	walkTaskIDs := make(map[string]bool)
 	walkFn := func(path string, info os.FileInfo, err error) error {
 		logrus.Debugf("start to walk path(%s)", path)
 
@@ -155,17 +155,13 @@ func getGCTasks(gapTasks, intervalTasks *treemap.Map) []string {
 
 	for _, v := range gapTasks.Values() {
 		if taskIDs, ok := v.([]string); ok {
-			for _, taskID := range taskIDs {
-				gcTasks = append(gcTasks, taskID)
-			}
+			gcTasks = append(gcTasks, taskIDs...)
 		}
 	}
 
 	for _, v := range intervalTasks.Values() {
 		if taskIDs, ok := v.([]string); ok {
-			for _, taskID := range taskIDs {
-				gcTasks = append(gcTasks, taskID)
-			}
+			gcTasks = append(gcTasks, taskIDs...)
 		}
 	}
 

supernode/daemon/mgr/cdn/manager.go

@@ -158,7 +158,7 @@ func (cm *Manager) TriggerCDN(ctx context.Context, task *types.TaskInfo) (*types
 
 	realMD5 := reader.Md5()
 	success, err := cm.handleCDNResult(ctx, task, realMD5, httpFileLength, downloadMetadata.realHTTPFileLength, downloadMetadata.realFileLength)
-	if err != nil || success == false {
+	if err != nil || !success {
 		return getUpdateTaskInfoWithStatusOnly(types.TaskInfoCdnStatusFAILED), err
 	}
 

supernode/daemon/mgr/cdn/reporter.go

@@ -58,7 +58,7 @@ func (re *reporter) reportCache(ctx context.Context, taskID string, metaData *fi
 	}
 
 	success, updateTaskInfo, err := re.processCacheByQuick(ctx, taskID, metaData, breakNum)
-	if err == nil && success == true {
+	if err == nil && success {
 		// it is possible to succeed only if breakNum equals -1
 		return nil, updateTaskInfo, nil
 	}