Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

the version 1.0.0 of dfget still have zombie processes after pull image #1086

Closed
liy516 opened this issue Nov 20, 2019 · 4 comments · Fixed by #1087
Closed

the version 1.0.0 of dfget still have zombie processes after pull image #1086

liy516 opened this issue Nov 20, 2019 · 4 comments · Fixed by #1087

Comments

@liy516
Copy link

liy516 commented Nov 20, 2019

phenomenon

[root@dragonfly01 dragonfly]# docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
99b11e0b94f0 192.168.56.102/common/dfclient:1.0.0 "/opt/dragonfly/df-c…" 22 minutes ago Up 6 minutes 0.0.0.0:65001->65001/tcp dfclient
[root@dragonfly01 dragonfly]# ps -ef | grep dfget
root 5039 4919 0 10:58 ? 00:00:00 [dfget]
root 5052 4919 0 10:58 ? 00:00:00 [dfget]
root 5057 4919 0 10:58 ? 00:00:00 [dfget]
root 5063 4919 0 10:58 ? 00:00:00 [dfget]
root 5604 2456 0 11:05 pts/0 00:00:00 grep --color=auto dfget

@liy516 liy516 changed the title the version 1.0.0 of dfget still have zombie processes the version 1.0.0 of dfget still have zombie processes after pull image Nov 20, 2019
@fengzixu
Copy link
Collaborator

Can you fill the re-produce method in this issue? I think it is beneficial for investigating the problem.

@liy516
Copy link
Author

liy516 commented Nov 20, 2019

Can you fill the re-produce method in this issue? I think it is beneficial for investigating the problem.

Pulling a new mirror produces the same number of zombie processes as the number of levels of the mirror.

@liy516
Copy link
Author

liy516 commented Nov 20, 2019

https://github.com/dragonflyoss/Dragonfly/blob/master/dfget/core/uploader/peer_server_executor.go#L75
https://github.com/dragonflyoss/Dragonfly/blob/master/dfget/core/uploader/peer_server_executor.go#L79
Locking after checking server seems to lead this.
You have submitted a PR, I try to compile your code and test it.

sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this issue May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants