Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

[feature request] make the dfget to get the list of supernodes more flexible #1293

Closed
lowzj opened this issue Apr 22, 2020 · 0 comments · Fixed by #1325
Closed

[feature request] make the dfget to get the list of supernodes more flexible #1293

lowzj opened this issue Apr 22, 2020 · 0 comments · Fixed by #1325
Labels
kind/feature kind/feature-request This is a feature request from community for project

Comments

@lowzj
Copy link
Member

lowzj commented Apr 22, 2020

Why you need it?

Now dfget gets the list of supernodes from configuration file or command line parameters.
It's inconvenient to update the list or

  • inconvenient to update client's configuration when scale up or scale down the supernodes cluster.
  • cannot customize the selection logic that better fits the user's scenario

How it could be?

Dragonfly defines the interface how to get supernodes and provides a default implementation that get supernodes from config/CLI. Then users can write a new implementation to select supernodes.

image

  • SupernodeLocator is defined interface which dfget's core flow invokes
  • StaticLocator is the default implementation Dragonfly provided
  • DynamicLocator is a user customized implementation for example:
    • it get supernode from StaticLocator firstly, and return it to caller if exists
    • otherwise, it get the list of supernodes from remote manager and store the result into local cache for next time

Other related information

@pouchrobot pouchrobot added kind/feature kind/feature-request This is a feature request from community for project labels Apr 22, 2020
@lowzj lowzj changed the title [feature request]: make the dfget to get the list of supernodes more flexible [feature request] make the dfget to get the list of supernodes more flexible Apr 22, 2020
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this issue May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature kind/feature-request This is a feature request from community for project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants