Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

[feature request] add minrate option for dfget #648

Closed
jyizheng opened this issue Jul 2, 2019 · 4 comments
Closed

[feature request] add minrate option for dfget #648

jyizheng opened this issue Jul 2, 2019 · 4 comments
Labels
kind/feature kind/feature-request This is a feature request from community for project

Comments

@jyizheng
Copy link
Contributor

jyizheng commented Jul 2, 2019 •
edited
Loading

Why you need it?

Let the client (dfget) to set the minimal rate, the default value can be 64 KB/s.

How it could be?

Other related information
@allencloud allencloud changed the title add minrate option for dfget [feature request] add minrate option for dfget Jul 3, 2019
@pouchrobot pouchrobot added kind/feature kind/feature-request This is a feature request from community for project labels Jul 3, 2019
@allencloud
Copy link
Contributor

Why you need it? If we do not have this feature, what shortcomings will be brought to the end users?
Could you be more specific? @jyizheng

@jyizheng
Copy link
Contributor Author

jyizheng commented Jul 3, 2019

Currently, the minimal download speed of Dragonfly is 64 KB/s, and Dragonfly uses this
number and the file size to estimate the total time of downloading a file. Some machines
may have very low download speed (<64 KB/s). For these machines, it could be useful to specify
"minrate" when running dfget so that they will not encounter TIMEOUT.

@yeya24
Copy link
Collaborator

yeya24 commented Jul 11, 2019

We can close this via dragonflyoss/dragonfly#664

@allencloud
Copy link
Contributor

We can close this via #664

Yes.

sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this issue May 8, 2022
@gaius-qi
feat: disable prepared statement (dragonflyoss#648)
5802cbc 
* feat: disable prepared statement

Signed-off-by: Gaius <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature kind/feature-request This is a feature request from community for project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jyizheng @allencloud @yeya24 @pouchrobot