This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
refactor: handle errors gracefully #1085
Merged
+34
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowzj
reviewed
Nov 19, 2019
starnop
force-pushed
the
retry-report
branch
from
9ab2316 to
2638fe9
Compare
Signed-off-by: Starnop <[email protected]>
starnop
force-pushed
the
retry-report
branch
from
2638fe9 to
d64938d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
- Coverage 47.33% 47.29% -0.05%
==========================================
Files 118 118
Lines 7216 7223 +7
==========================================
Hits 3416 3416
- Misses 3532 3539 +7
Partials 268 268
Continue to review full report at Codecov.
|
starnop
pushed a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
refactor: handle errors gracefully
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
refactor: handle errors gracefully
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
…flyoss#1085) When a peer leaves, it calls scheduler's LeaveTask() interface to notify scheduler that it's leaving. And LeaveTask() will re-schedule all its children to find a new parent by calling ScheduleParent(). But some of this peer's children might be in PeerStateSucceeded state, as they have finished downloading tasks from parent. So ScheduleParent() on such children is pointless. Let's delete peer's parent on PeerEventDownloadSucceeded event, so its parent won't call ScheduleParent() on it again, when its parent is leaving. Signed-off-by: Eryu Guan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews