fix: unset the default value of totallimit

[lowzj]

Signed-off-by: lowzj [email protected]

Ⅰ. Describe what this PR did

The total limit of dfget is used to limit downloading speed of all the tasks on the same host. It's designed to be set by user explicitly, it should not be set by default. Otherwise it doesn't work if users only set flag locallimit but not set totallimit.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

[starnop]

Could you please add more descriptions about why to submit this PR?

[codecov-io]

Codecov Report

Merging #1121 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1121      +/-   ##
==========================================
- Coverage   47.23%   47.22%   -0.01%     
==========================================
  Files         116      116              
  Lines        7205     7204       -1     
==========================================
- Hits         3403     3402       -1     
  Misses       3535     3535              
  Partials      267      267

Impacted Files	Coverage Δ
dfget/config/config.go	89.41% <ø> (-0.13%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49d466...c10fde1. Read the comment docs.

[starnop]

Then could you please delete the const value DefaultTotalLimit?

[starnop]

The total limit is used to limit downloading speed of all the tasks on the same host. It's designed to be set by user explicitly, it should not be set by default. Otherwise it doesn't work if users only set flag locallimit but not set totallimit.

In fact, dfdaemon will set a default totalLimit value for dfget. Should it be deleted?

[lowzj]

The total limit is used to limit downloading speed of all the tasks on the same host. It's designed to be set by user explicitly, it should not be set by default. Otherwise it doesn't work if users only set flag locallimit but not set totallimit.

In fact, dfdaemon will set a default totalLimit value for dfget. Should it be deleted?

It's unnecessary to delete it from dfdaemon. The dfdaemon is a specific usage scenario of dfget, it will start serval dfget processes at the same time when pulling an image, so the totallimit should be set. And the flag ratelimit of dfdaemon will set the totallimit and locallimit of dfget at the same time.

[SataQiu]

/LGTM

[starnop]

LGTM.