Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Refactor: make version subcommand as a public subcommand #1159

Merged
merged 1 commit into from
Jan 4, 2020

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jan 3, 2020

Signed-off-by: SataQiu [email protected]

Ⅰ. Describe what this PR did

Refactor: make version subcommand as a public subcommand

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #1159 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
- Coverage   47.23%   47.15%   -0.09%     
==========================================
  Files         116      113       -3     
  Lines        7217     7181      -36     
==========================================
- Hits         3409     3386      -23     
+ Misses       3540     3528      -12     
+ Partials      268      267       -1
Impacted Files Coverage Δ
cmd/supernode/app/root.go 68.94% <100%> (+0.16%) ⬆️
cmd/dfdaemon/app/root.go 66.66% <100%> (+0.36%) ⬆️
cmd/dfget/app/root.go 71.77% <100%> (+0.17%) ⬆️
supernode/daemon/mgr/scheduler/manager.go 22.6% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aaea24...6d98b90. Read the comment docs.

@starnop
Copy link
Contributor

starnop commented Jan 4, 2020

LGTM.

@starnop starnop merged commit 48a4736 into dragonflyoss:master Jan 4, 2020
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
* If the client output parameter is not specified, the client cannot automatically obtain the target file path

Signed-off-by: sunwp <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants