This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
test: add unit test case for func ParsePieceIndex #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guangwen Feng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
+ Coverage 47.13% 47.18% +0.04%
==========================================
Files 113 113
Lines 7181 7181
==========================================
+ Hits 3385 3388 +3
+ Misses 3528 3527 -1
+ Partials 268 266 -2
Continue to review full report at Codecov.
|
|
LGTM. @fenggw-fnst Thanks for your contribution. 😄 |
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guangwen Feng [email protected]
Ⅰ. Describe what this PR did
Add unit test case for func ParsePieceIndex
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
go test github.com/dragonflyoss/Dragonfly/supernode/util -run Test -v
Ⅴ. Special notes for reviews