This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
bugfix: retry multi times if failed to report pieces #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnop
force-pushed
the
retry-report-piece
branch
2 times, most recently
from
f9b1784 to
8075038
Compare
Codecov Report
@@ Coverage Diff @@
## master #1185 +/- ##
==========================================
- Coverage 47.66% 47.54% -0.13%
==========================================
Files 115 115
Lines 7225 7240 +15
==========================================
- Hits 3444 3442 -2
- Misses 3508 3524 +16
- Partials 273 274 +1
Continue to review full report at Codecov.
|
lowzj
reviewed
Jan 16, 2020
| } | ||
|
|
||
| var retry = 0 | ||
| var maxRetryTime = 3 |
There was a problem hiding this comment.
The following codes will send request to supernode at most 4 times, is it expected?
| break | ||
| } | ||
|
|
||
| sleepTime := time.Duration(rand.Intn(1000)+500) * time.Millisecond |
There was a problem hiding this comment.
The time to sleep is a bit long. It's better to decrease the interval time of first retry. How about [50, 500]ms?
starnop
force-pushed
the
retry-report-piece
branch
from
8075038 to
b7ec36e
Compare
Signed-off-by: Starnop <[email protected]>
starnop
force-pushed
the
retry-report-piece
branch
from
b7ec36e to
5d248de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
Sometimes dfget will fail to report pieces to supernode for some reason, such as supernode cannot handle it. And then supernode will mark that this task has not been completed forever. That's not expected. So we should add a retry mechanism to reduce the chance of errors.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews