This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
feature: support source cdn pattern #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnop
changed the title
starnop
changed the title
starnop
force-pushed
the
source-cdn
branch
3 times, most recently
from
4ddc723 to
8a786a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
- Coverage 48.51% 48.45% -0.07%
==========================================
Files 121 121
Lines 7682 7746 +64
==========================================
+ Hits 3727 3753 +26
- Misses 3649 3682 +33
- Partials 306 311 +5
Continue to review full report at Codecov.
|
lowzj
reviewed
Mar 17, 2020
starnop
force-pushed
the
source-cdn
branch
5 times, most recently
from
68e87db to
9a3ced9
Compare
lowzj
reviewed
Mar 23, 2020
supernode/util/range_util.go
Outdated
| if maxLength < 0 { | ||
| return pieceRange | ||
| } | ||
| indexs := strings.Split(pieceRange, separator) |
Signed-off-by: Starnop <[email protected]>
DONE. PTAL again. |
lowzj
approved these changes
Mar 24, 2020
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
) Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
As present, supernode will trigger CDN module to download the file from the source if not exist. However, that will cost some time. It's now allowed when someone wants to use the ability of P2P distribution without caching.
Restrictions
ContentLength.Ⅱ. Does this pull request fix one issue?
NONE.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
NONE.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews