Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

pkg/syncmap: add unit test for GetAsAtomicInt #1216

Merged
merged 1 commit into from
Feb 14, 2020
Merged

pkg/syncmap: add unit test for GetAsAtomicInt #1216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/syncmap/syncmap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import (
"testing"
"time"

"github.com/dragonflyoss/Dragonfly/pkg/atomiccount"

"github.com/go-check/check"
"github.com/willf/bitset"
)
Expand Down Expand Up @@ -131,3 +133,16 @@ func (suite *SyncMapUtilSuite) TestGetAsTime(c *check.C) {
result, _ := mmap.GetAsTime("aaa")
c.Check(result, check.DeepEquals, expected)
}

func (suite *SyncMapUtilSuite) TestGetAsAtomicInt(c *check.C) {
expected := atomiccount.NewAtomicInt(10)
mmap := NewSyncMap()
mmap.Add("aaa", expected)

result, _ := mmap.GetAsAtomicInt("aaa")
c.Check(result, check.DeepEquals, expected)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add code here to check the non-existent one, then check the non-nil error:

result, err := mmap.GetAsAtomicInt("nonexist")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, PTAL


result, err := mmap.GetAsAtomicInt("nonexist")
c.Check(err, check.NotNil)
c.Check(result, check.IsNil)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add c.Check(result, check.IsNil)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks.