Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

pkg/fileutils: add verifications and unit test for SymboliLlink #1223

Merged
merged 2 commits into from
Mar 7, 2020

Conversation

littleroad
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Dragonfly, @littleroad
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1223 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
- Coverage    47.9%   47.87%   -0.04%     
==========================================
  Files         118      118              
  Lines        7436     7443       +7     
==========================================
+ Hits         3562     3563       +1     
- Misses       3588     3591       +3     
- Partials      286      289       +3
Impacted Files Coverage Δ
pkg/fileutils/fileutils.go 74.79% <0%> (-2.79%) ⬇️
supernode/daemon/mgr/scheduler/manager.go 21.91% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a392463...17d7815. Read the comment docs.

pkg/fileutils/fileutils.go Outdated Show resolved Hide resolved
@allencloud
Copy link
Contributor

LGTM

@allencloud allencloud merged commit a47017f into dragonflyoss:master Mar 7, 2020
@littleroad littleroad deleted the symboliclink branch March 9, 2020 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants