Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

test: add unit test case for func WithMaxSizeMB #1241

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

fenggw-fnst
Copy link
Contributor

Signed-off-by: Guangwen Feng [email protected]

Ⅰ. Describe what this PR did

Add unit test case for func WithMaxSizeMB

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

go test github.com/dragonflyoss/Dragonfly/pkg/dflog -run Test -v

Ⅴ. Special notes for reviews

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit 35d3d7e into dragonflyoss:master Mar 13, 2020
@fenggw-fnst fenggw-fnst deleted the work branch March 13, 2020 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants