This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
update api definition of /peer/heartbeat and /peer/network #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
+ Coverage 48.96% 48.97% +0.01%
==========================================
Files 119 119
Lines 7763 7763
==========================================
+ Hits 3801 3802 +1
Misses 3647 3647
+ Partials 315 314 -1
Continue to review full report at Codecov.
|
wangforthinker
force-pushed
the
fix/update-heart-beat-api
branch
from
3aad901 to
112a234
Compare
wangforthinker
changed the title
allencloud
reviewed
Apr 10, 2020
allencloud
reviewed
Apr 10, 2020
apis/swagger.yml
Outdated
| in: query | ||
| required: true | ||
| description: "IP of peer." | ||
| type: "string" |
There was a problem hiding this comment.
In api defintion, paramter.types should in [string number boolean integer array], which could not set ipv4.
There was a problem hiding this comment.
format: 'ipv4' if we only support ipv4
wangforthinker
force-pushed
the
fix/update-heart-beat-api
branch
from
112a234 to
bfc8999
Compare
allencloud
reviewed
Apr 15, 2020
| @@ -1486,31 +1499,6 @@ definitions: | |||
| items: | |||
| $ref: "#/definitions/Node" | |||
|
|
|||
| HeartBeatRequest: | |||
There was a problem hiding this comment.
If the HTTP request method could be changed into POST, please remain the HeartBeatRequest here. That could be better.
Signed-off-by: allen.wq <[email protected]>
wangforthinker
force-pushed
the
fix/update-heart-beat-api
branch
from
bfc8999 to
702937c
Compare
|
LGTM |
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wq [email protected]
Ⅰ. Describe what this PR did
Update the api of /peer/heartbeat and /peer/network.
Ⅱ. Does this pull request fix one issue?
NONE.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews