Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

docs: fix typo #1287

Merged
merged 1 commit into from Apr 16, 2020
Merged

docs: fix typo #1287

merged 1 commit into from Apr 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 16, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @moyasu
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Dragonfly, @moyasu
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #1287 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
+ Coverage   49.73%   49.74%   +0.01%     
==========================================
  Files         120      120              
  Lines        7938     7938              
==========================================
+ Hits         3948     3949       +1     
  Misses       3666     3666              
+ Partials      324      323       -1     
Impacted Files Coverage Δ
supernode/daemon/mgr/scheduler/manager.go 22.60% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f1613...e942b10. Read the comment docs.

Signed-off-by: moyasu <[email protected]>
@allencloud
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 16, 2020
@allencloud allencloud merged commit 6681c18 into dragonflyoss:master Apr 16, 2020
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
* refactor: scheduler task SizeScope

Signed-off-by: Gaius <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
areas/docs areas/typo LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants