This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
feature: allow dfdaemon to listen port on 0~65535 #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found this is your first time to contribute to Dragonfly, @Komey |
…ort to listen. Signed-off-by: komey <[email protected]>
Komey
force-pushed
the
feature_expose_more_ports
branch
from
329c2f9 to
c84e38d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1300 +/- ##
=======================================
Coverage 51.11% 51.11%
=======================================
Files 122 122
Lines 8082 8082
=======================================
Hits 4131 4131
Misses 3622 3622
Partials 329 329
Continue to review full report at Codecov.
|
lowzj
changed the title
lowzj
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
modify dfdaemon port validate method, allow to expose more port to listen.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
test case
dfdaemon/config/config_test.go
Ⅴ. Special notes for reviews
Here is a case:
We have a private docker registry, named https://docker.pt.komey.com.
and we want to make our user to None care about the registry address,
So we'd like to config our DNS（docker.pt.komey.com） record for a specific region to 127.0.0.1 and expose dfdaemon on 443 port. Which may make our users have No feeling about the difference between the regions which didn't deploy dragonfly.