Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

feature: add Select api into SupernodeLocator #1345

Merged
merged 1 commit into from
May 18, 2020

Conversation

lowzj
Copy link
Member

@lowzj lowzj commented May 14, 2020

Signed-off-by: lowzj [email protected]

Ⅰ. Describe what this PR did

Providing a way for users to chooses a supernode based on the giving key.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #1345 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
- Coverage   51.35%   51.34%   -0.02%     
==========================================
  Files         130      130              
  Lines        8576     8578       +2     
==========================================
  Hits         4404     4404              
- Misses       3804     3806       +2     
  Partials      368      368              
Impacted Files Coverage Δ
dfget/locator/locator.go 100.00% <ø> (ø)
dfget/locator/static_locator.go 68.49% <0.00%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f131b5f...9864570. Read the comment docs.

@wangforthinker
Copy link
Contributor

LGTM

@lowzj lowzj force-pushed the locator-add-select branch from 7140edf to 6d3e5f6 Compare May 15, 2020 09:54
@lowzj lowzj force-pushed the locator-add-select branch from 6d3e5f6 to 9864570 Compare May 16, 2020 06:15
@lowzj lowzj merged commit d499c51 into dragonflyoss:master May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants