Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

move some types to basic package #1355

Merged

Conversation

wangforthinker
Copy link
Contributor

Signed-off-by: allen.wq [email protected]

Ⅰ. Describe what this PR did

Update types to basic package.

Ⅱ. Does this pull request fix one issue?

NONE.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

No need.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #1355 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1355   +/-   ##
=======================================
  Coverage   51.59%   51.59%           
=======================================
  Files         130      130           
  Lines        8605     8605           
=======================================
  Hits         4440     4440           
  Misses       3797     3797           
  Partials      368      368           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4350001...cefdca4. Read the comment docs.

@wangforthinker wangforthinker force-pushed the feat/update-dfget-interface-type-define branch from 09a1ab5 to cefdca4 Compare May 21, 2020 07:21
Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit 88cb9fa into dragonflyoss:master May 21, 2020
@wangforthinker wangforthinker deleted the feat/update-dfget-interface-type-define branch May 27, 2020 02:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants