This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
test: add unit test case for hashcircler_locator.go #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guangwen Feng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
==========================================
+ Coverage 52.02% 52.09% +0.07%
==========================================
Files 137 137
Lines 9108 9108
==========================================
+ Hits 4738 4745 +7
+ Misses 3987 3979 -8
- Partials 383 384 +1
Continue to review full report at Codecov.
|
|
@lowzj @zhouhaibing089 Hi! Could you PTAL, thanks! |
|
@zhouhaibing089 Can we get this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guangwen Feng [email protected]
Ⅰ. Describe what this PR did
Add unit test cases for hashcircler_locator.go
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews